virajjasani commented on code in PR #4924:
URL: https://github.com/apache/hbase/pull/4924#discussion_r1046590676
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java:
##########
@@ -265,6 +266,11 @@ public void replicateEntries(List<WALEntry> entries, final
CellScanner cells,
mutation.setClusterIds(clusterIds);
mutation.setAttribute(ReplicationUtils.REPLICATION_ATTR_NAME,
HConstants.EMPTY_BYTE_ARRAY);
+ if (attributeList != null) {
Review Comment:
> The goal of the WAL extended attribute is to pass some attributes down to
the replication implementation from the coproc implementation
That is correct but coproc would add it only so that it can consume it at
sink side correct? Otherwise who else would read WAL attributes from WALEntry
at sink side? HBase does it, while preparing for sink side mutations.
At sink side, once corpoc receives mutations generated by replication, it
cannot correlate the mutation with WAL extended attributes on it's own. Getting
these attributes consumed at sink side is the primary reason why corpoc would
like to pass some attributes down to replication implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
