Apache9 commented on code in PR #4924:
URL: https://github.com/apache/hbase/pull/4924#discussion_r1046591975
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java:
##########
@@ -265,6 +266,11 @@ public void replicateEntries(List<WALEntry> entries, final
CellScanner cells,
mutation.setClusterIds(clusterIds);
mutation.setAttribute(ReplicationUtils.REPLICATION_ATTR_NAME,
HConstants.EMPTY_BYTE_ARRAY);
+ if (attributeList != null) {
Review Comment:
> > The goal of the WAL extended attribute is to pass some attributes down
to the replication implementation from the coproc implementation
>
> That is correct but coproc would add it only so that it can consume it at
sink side correct? Otherwise who else would read WAL attributes from WALEntry
at sink side? HBase does it, while preparing for sink side mutations.
The original design is to read it in replication endpoint, IIRC. And also,
you can read it in ReplicationSink at the sink cluster, no problem.
The problem here is you want to add the WAL attributes to mutation's
attributes. This is a no no. We should not mix things up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
