apurtell commented on code in PR #5475:
URL: https://github.com/apache/hbase/pull/5475#discussion_r1373447217
##########
hbase-zookeeper/pom.xml:
##########
@@ -139,6 +139,15 @@
<artifactId>log4j-slf4j-impl</artifactId>
<scope>test</scope>
</dependency>
+ <!-- ZooKeeperServer needs the below dependencies, thus
MiniZooKeeperCluster also needs them -->
+ <dependency>
+ <groupId>org.xerial.snappy</groupId>
+ <artifactId>snappy-java</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>commons-cli</groupId>
+ <artifactId>commons-cli</artifactId>
Review Comment:
I think this one can be at test scope.
##########
hbase-zookeeper/pom.xml:
##########
@@ -139,6 +139,15 @@
<artifactId>log4j-slf4j-impl</artifactId>
<scope>test</scope>
</dependency>
+ <!-- ZooKeeperServer needs the below dependencies, thus
MiniZooKeeperCluster also needs them -->
+ <dependency>
+ <groupId>org.xerial.snappy</groupId>
+ <artifactId>snappy-java</artifactId>
Review Comment:
This undeclared dependency of recent zookeeper versions is annoying. We will
CNFE without it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
