Apache9 commented on code in PR #5475:
URL: https://github.com/apache/hbase/pull/5475#discussion_r1374654123
##########
hbase-zookeeper/pom.xml:
##########
@@ -139,6 +139,15 @@
<artifactId>log4j-slf4j-impl</artifactId>
<scope>test</scope>
</dependency>
+ <!-- ZooKeeperServer needs the below dependencies, thus
MiniZooKeeperCluster also needs them -->
+ <dependency>
+ <groupId>org.xerial.snappy</groupId>
+ <artifactId>snappy-java</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>commons-cli</groupId>
+ <artifactId>commons-cli</artifactId>
Review Comment:
We expose MiniZooKeeperCluster as IA.Public and it is under src/main, not
src/test, so we must declare the dependencies which are only used by zookeeper
server at compile/runtime scope...
IIRC there is a issue for removing the class but there are objections from
our users...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
