Apache9 commented on code in PR #5475:
URL: https://github.com/apache/hbase/pull/5475#discussion_r1374664331
##########
hbase-zookeeper/pom.xml:
##########
@@ -139,6 +139,15 @@
<artifactId>log4j-slf4j-impl</artifactId>
<scope>test</scope>
</dependency>
+ <!-- ZooKeeperServer needs the below dependencies, thus
MiniZooKeeperCluster also needs them -->
+ <dependency>
+ <groupId>org.xerial.snappy</groupId>
+ <artifactId>snappy-java</artifactId>
Review Comment:
Yes, I think a better way is to have a zookeeper-client module and a
zookeeper-server module. Now they only have a zookeeper module but they only
declare the dependencies for zookeeper-client at compile scope so we need to
manually add the zookeeper server dependencies...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
