Apache9 commented on code in PR #5475:
URL: https://github.com/apache/hbase/pull/5475#discussion_r1375141754
##########
hbase-common/pom.xml:
##########
@@ -97,6 +97,15 @@
<groupId>io.opentelemetry</groupId>
<artifactId>opentelemetry-semconv</artifactId>
</dependency>
+ <!-- include netty dependencies as hadoop needs them-->
Review Comment:
I only include the netty4 dependency here to reflect that we depend on
hadoop-common -> zookeeper, and the pre commit result seems fine. I'm not sure
whether netty4 is only used by zookeeper server but it is declared as a compile
scope dependency for zookeeper, so I prefer we add this dependency here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
