Apache9 commented on code in PR #5475:
URL: https://github.com/apache/hbase/pull/5475#discussion_r1375440445
##########
hbase-common/pom.xml:
##########
@@ -97,6 +97,14 @@
<groupId>io.opentelemetry</groupId>
<artifactId>opentelemetry-semconv</artifactId>
</dependency>
+ <!--
+ we depend on hadoop-common and hadoop-common depends on curator and
+ zookeeper, so we need to include netty4 dependency here
+ -->
+ <dependency>
Review Comment:
There is a nasty issue for netty that, some dependencies will use netty-all
while some others may use something like netty-handler, maven does not know
that netty-all includes netty-handler, so it will treat them as different
dependencies and then cause runtime class conflicts. So here we will exclude
all netty dependencies from our libraries, and then manually include netty-all.
You can see what we have done in the root pom file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
