bbeaudreault commented on code in PR #5475:
URL: https://github.com/apache/hbase/pull/5475#discussion_r1375456797
##########
hbase-common/pom.xml:
##########
@@ -97,6 +97,14 @@
<groupId>io.opentelemetry</groupId>
<artifactId>opentelemetry-semconv</artifactId>
</dependency>
+ <!--
+ we depend on hadoop-common and hadoop-common depends on curator and
+ zookeeper, so we need to include netty4 dependency here
+ -->
+ <dependency>
Review Comment:
I think we should include netty-bom with scope import and the version we
want. This will add all netty modules to our dependency management with the
same version. So then any transitive dependencies that depend on any netty
module will all use the same version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
