Apache9 commented on code in PR #5475:
URL: https://github.com/apache/hbase/pull/5475#discussion_r1375447715
##########
hbase-common/pom.xml:
##########
@@ -97,6 +97,14 @@
<groupId>io.opentelemetry</groupId>
<artifactId>opentelemetry-semconv</artifactId>
</dependency>
+ <!--
+ we depend on hadoop-common and hadoop-common depends on curator and
+ zookeeper, so we need to include netty4 dependency here
+ -->
+ <dependency>
Review Comment:
Oh, the newest netty-all module does not include any real classes, just
depend on all other netty modules...
But anyway, it could still lead to different versions of netty modules if we
rely on transitive dependencies of netty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
