Apache9 commented on code in PR #6129:
URL: https://github.com/apache/hbase/pull/6129#discussion_r1696193548
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RSProcedureDispatcher.java:
##########
@@ -471,9 +476,10 @@ public ServerOperation(RemoteProcedure remoteProcedure,
long procId, Class<?> rs
this.rsProcData = rsProcData;
}
- public RemoteProcedureRequest buildRequest() {
+ public RemoteProcedureRequest buildRequestWithMasterStartCode(long
masterStartCode) {
Review Comment:
Do not need to change the method I suppose.
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java:
##########
@@ -2567,6 +2573,17 @@ public ReportProcedureDoneResponse
reportProcedureDone(RpcController controller,
return ReportProcedureDoneResponse.getDefaultInstance();
}
+ private void throwOnOldMasterStartCode(Stream<Long> masterStartCodeStream)
Review Comment:
Could use LongStream here, but for me I prefer we log more about the
procedures here, like which procedure's master start code is greater than
current master's start code, and also log the start codes for better debugging.
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerServices.java:
##########
@@ -93,11 +93,14 @@ class PostOpenDeployContext {
private final HRegion region;
private final long openProcId;
private final long masterSystemTime;
+ private final long masterStartCode;
Review Comment:
Better add some comments or give it a more clear name so developers will
know that this is the start code of the master which scheduled this procedure,
for fencing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
