mnpoonia commented on code in PR #6129:
URL: https://github.com/apache/hbase/pull/6129#discussion_r1697981880
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java:
##########
@@ -2567,6 +2573,17 @@ public ReportProcedureDoneResponse
reportProcedureDone(RpcController controller,
return ReportProcedureDoneResponse.getDefaultInstance();
}
+ private void throwOnOldMasterStartCode(Stream<Long> masterStartCodeStream)
+ throws MasterNotRunningException {
+ long masterStartCodeFromProc =
masterStartCodeStream.max(Long::compare).orElse(-1L);
+ // -1 is less than any possible MasterStartCode
+
+ if (masterStartCodeFromProc > server.getStartcode()) {
Review Comment:
So if we throw exception here what would be the benefit of it. Will client
refresh the stub and go to currently active master?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
