mnpoonia commented on code in PR #6129:
URL: https://github.com/apache/hbase/pull/6129#discussion_r1697982844
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RSProcedureDispatcher.java:
##########
@@ -416,13 +416,17 @@ public void dispatchOpenRequests(final MasterProcedureEnv
env,
public void dispatchCloseRequests(final MasterProcedureEnv env,
final List<RegionCloseOperation> operations) {
for (RegionCloseOperation op : operations) {
- request.addCloseRegion(op.buildCloseRegionRequest(getServerName()));
+ request.addCloseRegion(op.buildCloseRegionRequest(getServerName(),
+ env.getMasterServices().getServerName().getStartCode()));
}
}
@Override
public void dispatchServerOperations(MasterProcedureEnv env,
List<ServerOperation> operations) {
- operations.stream().map(o ->
o.buildRequest()).forEachOrdered(request::addProc);
+ operations.stream()
+ .map(o -> o
+
.buildRequestWithMasterStartCode(env.getMasterServices().getServerName().getStartCode()))
Review Comment:
As suggested lets not change the method name here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
