Umeshkumar9414 commented on code in PR #6129:
URL: https://github.com/apache/hbase/pull/6129#discussion_r1696519759
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RSProcedureDispatcher.java:
##########
@@ -471,9 +476,10 @@ public ServerOperation(RemoteProcedure remoteProcedure,
long procId, Class<?> rs
this.rsProcData = rsProcData;
}
- public RemoteProcedureRequest buildRequest() {
+ public RemoteProcedureRequest buildRequestWithMasterStartCode(long
masterStartCode) {
Review Comment:
Method name ? or signture ?
I considered it while writing: should I add the masterStartCode directly to
the RemoteOperation class or pass it later? However, there's a significant
asymmetry in the code. The way we build the RegionOpenOperation,
RegionCloseOperation, and ServerOperation differs substantially from each other.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
