Apache9 commented on code in PR #6147:
URL: https://github.com/apache/hbase/pull/6147#discussion_r1713839151
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/RecoveredReplicationSource.java:
##########
@@ -49,6 +49,7 @@ protected RecoveredReplicationSourceShipper
createNewShipper(String walGroupId,
() -> {
if (workerThreads.isEmpty()) {
this.getSourceMetrics().clear();
+ this.terminate("Finished recovering queue");
Review Comment:
I think here we just need to call replicationEndpoint.stop? The terminate
method is designed for terminate a replication source when removing a peer or
refreshing a source when there are still data need to be replicated in the
source, so it contains a lot of unnecessary logics when we just want to remove
a finished recovered source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
