wdzaslzy commented on code in PR #6147:
URL: https://github.com/apache/hbase/pull/6147#discussion_r1716958836
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/RecoveredReplicationSource.java:
##########
@@ -49,6 +49,7 @@ protected RecoveredReplicationSourceShipper
createNewShipper(String walGroupId,
() -> {
if (workerThreads.isEmpty()) {
this.getSourceMetrics().clear();
+ this.terminate("Finished recovering queue");
Review Comment:
Yes, calling replicationEndpoint.stop can solve this bug. Don't the
workerThreads created during the initialization of RecoveredReplicationSource
need to be stopped? I think the context simply removes it from the map.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
