Apache9 commented on code in PR #6147:
URL: https://github.com/apache/hbase/pull/6147#discussion_r1716993864
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/RecoveredReplicationSource.java:
##########
@@ -49,6 +49,7 @@ protected RecoveredReplicationSourceShipper
createNewShipper(String walGroupId,
() -> {
if (workerThreads.isEmpty()) {
this.getSourceMetrics().clear();
+ this.terminate("Finished recovering queue");
Review Comment:
ReplicationSourceShipper is just a thread, it will quit after we returning
from the run method, so we do not need to stop it again. And even if you call
terminate method here, there is no way to close these threads as there is a
workerThreads.isEmpty check above...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
