wdzaslzy commented on code in PR #6147:
URL: https://github.com/apache/hbase/pull/6147#discussion_r1717813239


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/RecoveredReplicationSource.java:
##########
@@ -49,6 +49,7 @@ protected RecoveredReplicationSourceShipper 
createNewShipper(String walGroupId,
       () -> {
         if (workerThreads.isEmpty()) {
           this.getSourceMetrics().clear();
+          this.terminate("Finished recovering queue");

Review Comment:
   OK, thanks for your help. It is more reasonable to call 
replicationEndpoint.stop here without call terminate.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to