kgeisz commented on PR #7664: URL: https://github.com/apache/hbase/pull/7664#issuecomment-3785961493
> I have manually verified the bulk load directory is empty right before it is deleted, but this check has not been implemented into a unit test. I looked into how this could be tested. This check would need to be performed after IncrementalTableBackupClient.handleBulkLoad(). The only place I see this method in current test code is in [TestBackupBase](https://github.com/apache/hbase/blob/master/hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupBase.java#L196), and this code is for non-continuous incremental backups. Based on what I have found, handling this test case would require code changes beyond the scope of this PR that involve creating a test similar to the one in TestBackupBase or overriding IncrementalTableBackupClient.execute() in a test class to have it check the directory is empty and then delete. Another thought I had is to add an `assert` directly in `IncrementalTableBackupClient.execute()` that checks the directory is empty before performing the delete, but I'm not sure that we want the backup to fail on the off chance that the `assert` fails. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
