kgeisz commented on code in PR #7664:
URL: https://github.com/apache/hbase/pull/7664#discussion_r2722344314
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/IncrementalTableBackupClient.java:
##########
@@ -403,13 +403,17 @@ public void execute() throws IOException,
ColumnFamilyMismatchException {
failBackup(conn, backupInfo, backupManager, e, "Unexpected Exception : ",
BackupType.INCREMENTAL, conf);
throw new IOException(e);
+ } finally {
+ if (backupInfo.isContinuousBackupEnabled()) {
+ deleteBulkLoadDirectory();
+ }
Review Comment:
I added the `if (backupInfo.isContinuousBackupEnabled())` statement since
this directory is created again for continuous backups only. If we didn't have
this `if` statement, then we would see something like `Could not delete...` for
non-continuous backups (also pointed out by Copilot).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
