taklwu commented on code in PR #7664:
URL: https://github.com/apache/hbase/pull/7664#discussion_r2722421043
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/IncrementalTableBackupClient.java:
##########
@@ -403,13 +403,17 @@ public void execute() throws IOException,
ColumnFamilyMismatchException {
failBackup(conn, backupInfo, backupManager, e, "Unexpected Exception : ",
BackupType.INCREMENTAL, conf);
throw new IOException(e);
+ } finally {
+ if (backupInfo.isContinuousBackupEnabled()) {
+ deleteBulkLoadDirectory();
+ }
Review Comment:
I will approve it, but my point is that, if two steps have to delete the
same root of `BulkOutputDir` , can't we delete only once ? or delete only the
directory related to step of `INCREMENTAL_COPY` and `INCR_BACKUP_COMPLETE` ,
and at the end deleting the `BulkOutputDir`.
it's very hard to figure out why we would need to recreate the
`BulkOutputDir` twice as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
