taklwu commented on code in PR #7664:
URL: https://github.com/apache/hbase/pull/7664#discussion_r2718391153
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/IncrementalTableBackupClient.java:
##########
@@ -403,13 +403,17 @@ public void execute() throws IOException,
ColumnFamilyMismatchException {
failBackup(conn, backupInfo, backupManager, e, "Unexpected Exception : ",
BackupType.INCREMENTAL, conf);
throw new IOException(e);
+ } finally {
+ if (backupInfo.isContinuousBackupEnabled()) {
+ deleteBulkLoadDirectory();
+ }
Review Comment:
nit: why don't we always delete the `deleteBulkLoadDirectory` ? please see
in the function of `incrementalCopyHFiles`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
