[
https://issues.apache.org/jira/browse/HBASE-6659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446111#comment-13446111
]
stack commented on HBASE-6659:
------------------------------
Your responses are many and do not cite to what you are responding which makes
it tough aligning what your response refers to. For example, this comment:
bq. In HBaseTestingUtility, I don't see getRegionsByServer().
To what of my remarks is it in reply to?
On the keeping TestHLogFiltering, thats fine. You give good rationale.
bq. The timing of this call is not in sync with region server heartbeat.
Nevermind my comment; I had the workings mixed up.
bq. But I found that code would get more convoluted that way.
Yes. Its super ugly rpc'ing the master from down deep in hlogsplitter. Could
we put the rpc behind an Interface at least?
bq. w.r.t. introduction of void flushRegion(byte[] regionName), you're right
that flushRegion(final RpcController controller, final FlushRegionRequest
request) requires the composition of FlushRegionRequest. So that method is
called by client.
I don't follow what you are saying above.
bq. Since 0.96 hasn't been released, I think adding methods to MasterServices
should be acceptable.
My rationale for not adding methods has nothing to do w/ whether a release has
been made or not; its about keeping these Interfaces as basic as possible so
mocking does not become burdensome (when mocking is burdensome, fellas will
skip on writing tests)
bq. w.r.t. flushedSequenceIdByRegion map, there is no other map in HMaster
which is keyed by byte[] (region name).
There is at least AM#regions
Its use is different but I'd think some effort would be expended trying to make
it so we don't proliferate state keepers per facility added to hbase. Maybe
its not possible.
> Port HBASE-6508 Filter out edits at log split time
> --------------------------------------------------
>
> Key: HBASE-6659
> URL: https://issues.apache.org/jira/browse/HBASE-6659
> Project: HBase
> Issue Type: Bug
> Reporter: Zhihong Ted Yu
> Assignee: Zhihong Ted Yu
> Fix For: 0.96.0
>
> Attachments: 6508-v2.txt, 6508-v3.txt, 6508-v4.txt, 6508-v5.txt,
> 6508-v6.txt
>
>
> HBASE-6508 is for 0.89-fb branch.
> This JIRA ports the feature to trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
