[
https://issues.apache.org/jira/browse/HBASE-6659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446640#comment-13446640
]
Ted Yu commented on HBASE-6659:
-------------------------------
bq. load is carrying non-load attributes
I will add javadoc as you suggested on review board.
bq. a bit of improvement over having to pass info from HMaster to SM and then
back to HMaster
Sequence Id information is passed from region servers to ServerManager, from
ServerManager to Master, if that is what you meant.
I checked a few methods in ServerManager, such as:
{code}
public Map<ServerName, ServerLoad> getOnlineServers() {
public Set<ServerName> getDeadServers() {
{code}
They are all consumed in org.apache.hadoop.hbase.master namespace. Since
ServerManager doesn't implement interface, currently I don't see how
LastFlushedSequenceIds can be encapsulated within ServerManager.
w.r.t. creating LastSequenceId interface, currently neither SplitLogWorker nor
HLogSplitter has reference to RegionServerServices.
If I understand your suggestion correctly, 'long getLastSequenceId(regionname)'
can be added to RegionServerServices. We pass reference of RegionServerServices
from region server to SplitLogWorker, then to HLogSplitter.
HLogSplitter would be able to consume this new method.
Once I get your confirmation, I would come up with patch v8.
> Port HBASE-6508 Filter out edits at log split time
> --------------------------------------------------
>
> Key: HBASE-6659
> URL: https://issues.apache.org/jira/browse/HBASE-6659
> Project: HBase
> Issue Type: Bug
> Reporter: Zhihong Ted Yu
> Assignee: Zhihong Ted Yu
> Fix For: 0.96.0
>
> Attachments: 6508-v2.txt, 6508-v3.txt, 6508-v4.txt, 6508-v5.txt,
> 6508-v7.txt, 6508-v7.txt
>
>
> HBASE-6508 is for 0.89-fb branch.
> This JIRA ports the feature to trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
