[
https://issues.apache.org/jira/browse/HBASE-6659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449808#comment-13449808
]
stack commented on HBASE-6659:
------------------------------
+1
To me at least, we encapsulate the sequenceid counting inside ServerManager
rather than have it spread between SM and HM (also, don't need to add an
esoteric method to the generic MasterServices Interface). HLogSplitter is
passed a specific Interface for getting last sequenceid rather than a protocol
implementation. I think this better. Thanks for entertaining my reviews.
On commit remove '+ * Copyright The Apache Software Foundation' and change this
'+ * @param master' (param name is different).
This change seems gratuitous but it is from original patch so its ok:
{code}
- regionInfo.getTableName(), completeSequenceId,
+ regionInfo.getTableName(), completeSeqId,
{code}
Are the imports in MasterServices needed? (they don't seem to be referred to by
this patch). Remove on commit.
> Port HBASE-6508 Filter out edits at log split time
> --------------------------------------------------
>
> Key: HBASE-6659
> URL: https://issues.apache.org/jira/browse/HBASE-6659
> Project: HBase
> Issue Type: Bug
> Reporter: Zhihong Ted Yu
> Assignee: Ted Yu
> Fix For: 0.96.0
>
> Attachments: 6508-v2.txt, 6508-v3.txt, 6508-v4.txt, 6508-v5.txt,
> 6508-v7.txt, 6508-v8.txt
>
>
> HBASE-6508 is for 0.89-fb branch.
> This JIRA ports the feature to trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
