[
https://issues.apache.org/jira/browse/HBASE-6659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449453#comment-13449453
]
stack commented on HBASE-6659:
------------------------------
bq. They are all consumed in org.apache.hadoop.hbase.master namespace. Since
ServerManager doesn't implement interface, currently I don't see how
LastFlushedSequenceIds can be encapsulated within ServerManager.
Sorry. I don't follow what you are saying above.
updateLastFlushedSequenceIds is implemented in HMaster and used by
ServerManager. So ServerManager can use updateLastFlushedSequenceIds you must
add it to MasterServices. Can you better encapsulate this new sequenceid to
region accounting by moving it all into ServerManager so you do not have to do
this back and forth between SM and HM and you can avoid adding more facility to
the MasterServices Interface? Looking at updateLastFlushedSequenceIds
implementation I do not see an obvious reason why we could not but I may be
missing something.
bq. We pass reference of RegionServerServices from region server to
SplitLogWorker, then to HLogSplitter. HLogSplitter would be able to consume
this new method.
The above is basically right (We'd pass a reference to a LastSequenceId
Interface -- though the actual instance may be a RegionServerServices that
implements LastSequenceId).
Do you think this makes sense? Would it be a PITA to do? We'd pass this
Interface instead of passing in the crazy RegionServerStatusProtocol masterRef
(A LastSequenceId would be easy to mock, a RegionServerStatusProtocol would be
a pain)
> Port HBASE-6508 Filter out edits at log split time
> --------------------------------------------------
>
> Key: HBASE-6659
> URL: https://issues.apache.org/jira/browse/HBASE-6659
> Project: HBase
> Issue Type: Bug
> Reporter: Zhihong Ted Yu
> Assignee: Zhihong Ted Yu
> Fix For: 0.96.0
>
> Attachments: 6508-v2.txt, 6508-v3.txt, 6508-v4.txt, 6508-v5.txt,
> 6508-v7.txt, 6508-v7.txt
>
>
> HBASE-6508 is for 0.89-fb branch.
> This JIRA ports the feature to trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
