[
https://issues.apache.org/jira/browse/HBASE-7763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574941#comment-13574941
]
Sergey Shelukhin commented on HBASE-7763:
-----------------------------------------
{code}
- /**
- * FILE_SIZE = descending sort StoreFiles (largest --> smallest in size)
- */
- static final Comparator<StoreFile> FILE_SIZE = Ordering.natural().reverse()
{code}
Removed due to lack of usage?
{code}
long[] seeds = new long[] {
{code}
If a fixed set of random numbers is needed, maybe they can be generated by
Random w/fixed seed? Then used
as seeds to separate randoms if needed.
{code}
+ List<StoreFile> storeFiles = new ArrayList<StoreFile>(startingStoreFiles);
+ CompactSelection sel = cp.selectCompaction(new
ArrayList<StoreFile>(storeFiles), false, false);
{code}
Lots of lists created around this area. At least the first one looks not
useful, as it's never used without wrapping again.
Nit: spacing, like
{code}
+ for (int i =0; i< 50; i++) {
{code}
There are some double blank lines also.
Can number of iterations be a const, or configurable?
> Compactions not sorting based on size anymore.
> ----------------------------------------------
>
> Key: HBASE-7763
> URL: https://issues.apache.org/jira/browse/HBASE-7763
> Project: HBase
> Issue Type: Bug
> Components: Compaction
> Affects Versions: 0.96.0, 0.94.4
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Critical
> Fix For: 0.96.0, 0.94.6
>
> Attachments: HBASE-7763-trunk-1.patch, HBASE-7763-trunk-2.patch,
> HBASE-7763-trunk-TESTING.patch, HBASE-7763-trunk-TESTING.patch,
> HBASE-7763-trunk-TESTING.patch
>
>
> Currently compaction selection is not sorting based on size. This causes
> selection to choose larger files to re-write than are needed when bulk loads
> are involved.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
