[
https://issues.apache.org/jira/browse/HBASE-7763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574981#comment-13574981
]
Elliott Clark commented on HBASE-7763:
--------------------------------------
bq.Removed due to lack of usage?
Yep. That plus the fact that it's usage is not needed and would be wrong.
bq.If a fixed set of random numbers is needed, maybe they can be generated by
Random w/fixed seed? Then used
as seeds to separate randoms if needed.
Done
bq.Lots of lists created around this area. At least the first one looks not
useful, as it's never used without wrapping again.
Yep, since filesToCompact and the storeFiles are different parts of the same
list we need to do some copying to keep away from concurrent modification
exceptions. I removed the one extra that was un-needed.
bq.Nit: spacing, like
Fixed.
bq.Should LOG be used above ?
Nope. Logger adds way too many other things into a string. I used sysout so
that it can be piped into a tab delim file.
> Compactions not sorting based on size anymore.
> ----------------------------------------------
>
> Key: HBASE-7763
> URL: https://issues.apache.org/jira/browse/HBASE-7763
> Project: HBase
> Issue Type: Bug
> Components: Compaction
> Affects Versions: 0.96.0, 0.94.4
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Critical
> Fix For: 0.96.0, 0.94.6
>
> Attachments: HBASE-7763-trunk-1.patch, HBASE-7763-trunk-2.patch,
> HBASE-7763-trunk-3.patch, HBASE-7763-trunk-TESTING.patch,
> HBASE-7763-trunk-TESTING.patch, HBASE-7763-trunk-TESTING.patch
>
>
> Currently compaction selection is not sorting based on size. This causes
> selection to choose larger files to re-write than are needed when bulk loads
> are involved.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
