[
https://issues.apache.org/jira/browse/HBASE-7763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574942#comment-13574942
]
Ted Yu commented on HBASE-7763:
-------------------------------
For PerfTestCompactionPolicy:
{code}
+ public static Collection<Object[]> data() {
+ return Arrays.asList(new Object[][] {
+ {"Default", new DefaultCompactionPolicy(), 3, 2, 1.2f},
+ {"Default", new DefaultCompactionPolicy(), 4, 2, 1.2f},
+ {"Default", new DefaultCompactionPolicy(), 5, 2, 1.2f},
+ {"Default", new DefaultCompactionPolicy(), 4, 2, 1.3f},
+ {"Default", new DefaultCompactionPolicy(), 4, 2, 1.4f},
{code}
I think other compaction policies would be added to the above list. Should the
test be named PerfTestCompactionPolicies ?
{code}
+ public PerfTestCompactionPolicy(String name, CompactionPolicy cp, int max,
int min, float ratio) {
{code}
Please add javadoc for the parameters.
{code}
+ static final Log LOG = LogFactory.getLog(PerfTestCompactionPolicy.class);
...
+ //print out tab delimited so that it can be used in excel/gdocs.
+ System.out.println(
+ name
{code}
Should LOG be used above ?
> Compactions not sorting based on size anymore.
> ----------------------------------------------
>
> Key: HBASE-7763
> URL: https://issues.apache.org/jira/browse/HBASE-7763
> Project: HBase
> Issue Type: Bug
> Components: Compaction
> Affects Versions: 0.96.0, 0.94.4
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Critical
> Fix For: 0.96.0, 0.94.6
>
> Attachments: HBASE-7763-trunk-1.patch, HBASE-7763-trunk-2.patch,
> HBASE-7763-trunk-TESTING.patch, HBASE-7763-trunk-TESTING.patch,
> HBASE-7763-trunk-TESTING.patch
>
>
> Currently compaction selection is not sorting based on size. This causes
> selection to choose larger files to re-write than are needed when bulk loads
> are involved.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
