[ 
https://issues.apache.org/jira/browse/HBASE-7948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13596255#comment-13596255
 ] 

stack commented on HBASE-7948:
------------------------------

HRegionCacheLocation just has seqid in it now.  Is that enough to justify 
separate class?  If you left it in RegionLocation, your patch would be a good 
bit smaller again (smile).

Is the class comment on RegionOpeningException right?  Is it copy/paste?

Higher-level, patch looks good (the intent that is).

Also, higher-level again, agree w/ [~nkeywal] philosophy of lets remove the 
papering over of issues -- in this case the timeout on cache (as has been done 
in last version of patch) -- and rather reveal sooner the broke regionserver 
rather than hope that a trip to .META. will magically fix it all.

Good stuff Sergey. 


                
> client doesn't need to refresh meta while the region is opening
> ---------------------------------------------------------------
>
>                 Key: HBASE-7948
>                 URL: https://issues.apache.org/jira/browse/HBASE-7948
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: HBASE-7948-v0.patch, HBASE-7948-v1.patch, 
> HBASE-7948-v1.patch, HBASE-7948-v2.patch, HBASE-7948-v3.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to