[
https://issues.apache.org/jira/browse/HBASE-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649204#comment-13649204
]
stack commented on HBASE-7897:
------------------------------
Good one [~ram_krish]
Looking at the implementation, though it is what [~mcorgan] suggested, I'm
thinking the implementation of the tag parse escapes Cell -- the CellUtil needs
to know how the encoding is done to parse or put an Iterator on tags? If we
added hasTags, Map getTags, and byte [] getTag(byte [] tagName), would this
allow tags to be impemented diffrently and up to the Cell implementation how
tags are parsed?
It might help if we had some examples of 'tags'?
Accumulo's column visibility looks like this:
http://accumulo.apache.org/1.4/apidocs/org/apache/accumulo/core/security/ColumnVisibility.html#ColumnVisibility(byte[])
When we say tags, are we saying a set of key/values? So in hbase, there would
be a tag whose key is 'vis' for 'column visibility' but that there might be
another tag on the same keyvalue which would be 'cid' for cluster id, the id
that the keyvalue was originally added one to help w/ replication?
You say above that tags can be multiple in the one key.
If so, the API doesn't seem to lend itself to being able to ask for a
particular tag; outside of the Cell implementation we'd have to make sense of
the bytes we got out of the Cell?
There is something weird in the formatting in TestPayloadCarryingRpcController
> Add support for tags to Cell Interface
> --------------------------------------
>
> Key: HBASE-7897
> URL: https://issues.apache.org/jira/browse/HBASE-7897
> Project: HBase
> Issue Type: Task
> Reporter: stack
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 0.95.1
>
> Attachments: HBASE-7897.patch
>
>
> Cell Interface has suppport for mvcc. The only thing we'd add to Cell in
> the near future is support for tags it would seem. Should be easy to add.
> Should add it now. See backing discussion here:
> https://issues.apache.org/jira/browse/HBASE-7233?focusedCommentId=13573784&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13573784
> Matt outlines what the additions to Cell might look like here:
> https://issues.apache.org/jira/browse/HBASE-7233?focusedCommentId=13531619&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13531619
> Would be good to get these in now.
> Marking as 0.96. Can more later.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
