[
https://issues.apache.org/jira/browse/HBASE-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649279#comment-13649279
]
stack commented on HBASE-7897:
------------------------------
Ok on hasTags [~mcorgan]
bq. I'm worried about adding methods that require object creation. Map
getTags() and byte[] getTag would be very expensive if used in a long scan
where most cells are filtered out.
Fair enough but having it so we have to delegate to a helper class to make
sense of the tag bytes precludes our ever being able to encode them? We ok w/
that? I'd think that tags would rarely vary across Cells so something like a
"byte [] getTag(byte [] key)" would be "expensive" on first invocation, yeah,
but thereafter we'd just keep returning the already-made tag value?
What we thinking for tags? A one byte 'key'? That'd allow us 256 tag keys.
That should be enough (origin cluster, column visibility, and probably one or
two more tags ever?). And then a varint length for the value?
> Add support for tags to Cell Interface
> --------------------------------------
>
> Key: HBASE-7897
> URL: https://issues.apache.org/jira/browse/HBASE-7897
> Project: HBase
> Issue Type: Task
> Reporter: stack
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 0.95.1
>
> Attachments: HBASE-7897.patch
>
>
> Cell Interface has suppport for mvcc. The only thing we'd add to Cell in
> the near future is support for tags it would seem. Should be easy to add.
> Should add it now. See backing discussion here:
> https://issues.apache.org/jira/browse/HBASE-7233?focusedCommentId=13573784&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13573784
> Matt outlines what the additions to Cell might look like here:
> https://issues.apache.org/jira/browse/HBASE-7233?focusedCommentId=13531619&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13531619
> Would be good to get these in now.
> Marking as 0.96. Can more later.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
