[ 
https://issues.apache.org/jira/browse/HBASE-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649361#comment-13649361
 ] 

ramkrishna.s.vasudevan commented on HBASE-7897:
-----------------------------------------------

I have some doubts on the above discussions.
My first question would be, are we going with different Encoders for the Tags?  
Which means the normal keyvalue will be encoded differently and the tags will 
be encoded differently?
I can provide more details on this once am done with some more internal work.
bq. If we added hasTags, Map getTags, and byte [] getTag(byte [] tagName), 
would this allow tags to be impemented diffrently and up to the Cell 
implementation how tags are parsed?
First i think we can have mutliple tags per KV.  Something like Visibility tag 
and the other one could be an ACL tag.
So we may have to provide an iterator which would help us to get the different 
tags.  So the iterator should have an idea as how the tags would look like. 
This is what i thought :).  Open for discussion on any of the above points.
bq. the API doesn't seem to lend itself to being able to ask for a particular 
tag
I had an api for this but did not attach it in the patch.  The idea was the 
KeyValue will have something called Tag, and it will have the Type and the 
Actual tag byte array.  
So if i say get me the Tag Type Visibility this iterator will iterate 
internally and give us that particular tag byte array that corresponds to 
Visibility.
Again the tags cannot be overwritten just that every tag goes with that 
individual KV/Cell.
I can provide some more details on what is planned and what is done after some 
internal discussions.






                
> Add support for tags to Cell Interface
> --------------------------------------
>
>                 Key: HBASE-7897
>                 URL: https://issues.apache.org/jira/browse/HBASE-7897
>             Project: HBase
>          Issue Type: Task
>            Reporter: stack
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Critical
>             Fix For: 0.95.1
>
>         Attachments: HBASE-7897.patch
>
>
> Cell Interface has suppport for mvcc.   The only thing we'd add to Cell in 
> the near future is support for tags it would seem.  Should be easy to add.  
> Should add it now.  See backing discussion here: 
> https://issues.apache.org/jira/browse/HBASE-7233?focusedCommentId=13573784&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13573784
> Matt outlines what the additions to Cell might look like here:
> https://issues.apache.org/jira/browse/HBASE-7233?focusedCommentId=13531619&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13531619
> Would be good to get these in now.
> Marking as 0.96.  Can more later.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to