[
https://issues.apache.org/jira/browse/HBASE-8420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13665759#comment-13665759
]
Jimmy Xiang commented on HBASE-8420:
------------------------------------
bq. I think the return value should be checked so that we know whether
prefetchedResultSize should be deducted from globalPrefetchedResultSize.
prefetchedResultSize will be updated if the task is going on. So, no matter
what the cancel returns, as long as we deduct prefetchedResultSize, it will be
good.
bq. What if tmp.results.size + scanResult.results.size() > this.rows ?
That will be ok. ClientScanner can handle that with no problem.
bq. Maybe the above class can reside in HRegionServer ?
I put here since HRegionServer is too big.
I have fixed the other issues you pointed out. Thanks.
> Port HBASE-6874 Implement prefetching for scanners from 0.89-fb
> -----------------------------------------------------------------
>
> Key: HBASE-8420
> URL: https://issues.apache.org/jira/browse/HBASE-8420
> Project: HBase
> Issue Type: Improvement
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Attachments: 0.94-8420_v1.patch, 0.94-8420_v2.patch,
> trunk-8420_v1.patch, trunk-8420_v2.patch, trunk-8420_v3.patch,
> trunk-8420_v4.patch, trunk-8420_v5.1.patch, trunk-8420_v5.patch,
> trunk-8420_v6.patch
>
>
> This should help scanner performance. We should have it in trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
