[
https://issues.apache.org/jira/browse/HIVE-18755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414149#comment-16414149
]
Alan Gates commented on HIVE-18755:
-----------------------------------
I will change the various calls to take unique requests.
I don't want to make the catalogs optional anywhere. Going forward we want
them to be part of all calls. As the API grows (and hopefully as we build a
v2) we want all new calls to include them.
On the comments about getCatalogs(), I don't plan to add a request structure as
I don't envision there ever being a structure above catalogs (since that's the
way SQL defines it).
As to getCatalogs returning a list of strings, it matches the name of
getDatabases, which returns a list of DB names.
On auto-creation of catalogs, I definitely do not want to do that. When I get
to the security section my intention is to make it so that only admin's can
create catalogs. How I'll enforce that on the metastore side I haven't figured
out. But I don't want it to be easy to create catalogs.
On catalog location, it needs a default location. Today if you create a
database without specifying a location it defaults to the warehouse root. That
won't work once we have catalogs because there could be two databases D (one in
catalog C1 and one in catalog C2) both created without a location specified.
Therefore a catalog has to have a location. The 'hive' catalog (the default)
has a location of the warehouse root to match the current behavior. Once we
have to have the location it makes sense to make it a field, since it will
always be there.
{quote}Note that this removes use of ConcurrentMaps with non concurrent ones in
SharedCache. But with the read/write locking that is already in place, that
seems to be fine.
{quote}
It was not my intent to change anything in SharedCache other than make it work
with catalogs. Any change from ConcurrentMap to Map was unintentional. I
agree Daniel and Vaibhav should take a look to make sure my changes there make
sense.
> Modifications to the metastore for catalogs
> -------------------------------------------
>
> Key: HIVE-18755
> URL: https://issues.apache.org/jira/browse/HIVE-18755
> Project: Hive
> Issue Type: Sub-task
> Components: Metastore
> Reporter: Alan Gates
> Assignee: Alan Gates
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.0.0
>
> Attachments: HIVE-18755.2.patch, HIVE-18755.nothrift, HIVE-18755.patch
>
>
> Step 1 of adding catalogs is to add support in the metastore.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
