Sahil Takiar commented on HIVE-19104:

A few comments:

Why not just delete the entry for {{javax.jdo.option.ConnectionURL}} from 
{{data/conf/hive-site.xml}} and force tests to explicitly set it (or change 
{{MetaStoreUtils.java}} to ignore the set value). This seems a bit cleaner (and 
easier to follow) than replacing {{junit_metastore_db}} with 
{{junit_metastore_db_[port]}}. Ideally, the name of the database set in the 
connection URL in the {{hive-site.xml}} shouldn't matter, this approach adds an 
implicit dependency on the name.

Why are the changes to {{TestHiveMetaStore}} necessary?

> When test MetaStore is started with retry the instances should be independent
> -----------------------------------------------------------------------------
>                 Key: HIVE-19104
>                 URL: https://issues.apache.org/jira/browse/HIVE-19104
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Peter Vary
>            Assignee: Peter Vary
>            Priority: Major
>         Attachments: HIVE-19104.2.patch, HIVE-19104.3.patch, HIVE-19104.patch
> When multiple MetaStore instances are started with 
> {{MetaStoreTestUtils.startMetaStoreWithRetry}} currently they use the same 
> JDBC url, and warehouse directory. This can cause problem in the tests

This message was sent by Atlassian JIRA

Reply via email to