Peter Vary commented on HIVE-19104:

bq. Why not just delete the entry for javax.jdo.option.ConnectionURL from 
data/conf/hive-site.xml and force tests to explicitly set it (or change 
MetaStoreUtils.java to ignore the set value). 

The purpose of the MetaStoreTestUtils is to allow easy metastore instance 
creation for tests and the user should not have to bother with details, like 
making the jdbc url independent. On the other hand I did want to have the 
possibility to define the jdbc url if needed. This is the same approach I 
followed with the warehouse dir. If you have better ideas, I am open for 
anything, since I am not entirely comfortable with this solution.

bq. Why are the changes to TestHiveMetaStore necessary?

Otherwise when running the second test the @Before method will regenerate the 
conf changes (port settings, warehouse dir changes etc)

> When test MetaStore is started with retry the instances should be independent
> -----------------------------------------------------------------------------
>                 Key: HIVE-19104
>                 URL: https://issues.apache.org/jira/browse/HIVE-19104
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Peter Vary
>            Assignee: Peter Vary
>            Priority: Major
>         Attachments: HIVE-19104.2.patch, HIVE-19104.3.patch, HIVE-19104.patch
> When multiple MetaStore instances are started with 
> {{MetaStoreTestUtils.startMetaStoreWithRetry}} currently they use the same 
> JDBC url, and warehouse directory. This can cause problem in the tests

This message was sent by Atlassian JIRA

Reply via email to