Peter Vary commented on HIVE-19104:

This patch is becoming bigger, so probably a review board is already needed to 
properly review it:  [https://reviews.apache.org/r/66585/]

[~stakiar]: Changes in this patch:
 * Fixed several failed tests revealed by the precommit tests.
 * Moved the configuration initialization to static as discussed
 * Checked what can I do with the JDBC, and warehouse directory configuration. 
They are using System variables (pom.xml based, which can be overwritten by -D 
flags) to initialize the values in the configuration:
  <!--  this should eventually be deprecated since the metastore should supply 
this -->
Also these values are used by other tests, so we can not remove them from the 
tests entirely.

So I do not think we could remove them from the config file. And for example 
the MiniHS2 intentionally changes the warehouse directory based on the settings.

So in this patch I would not change the jdbc url and the warehouse directory 
handling, and on the long run I would be more comfortable moving all of the 
tests to using the MiniHMS for MetaStore handling.

Is this ok with you [~stakiar]?

Thanks for taking the time and reviewing this stuff!


> When test MetaStore is started with retry the instances should be independent
> -----------------------------------------------------------------------------
>                 Key: HIVE-19104
>                 URL: https://issues.apache.org/jira/browse/HIVE-19104
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Peter Vary
>            Assignee: Peter Vary
>            Priority: Major
>         Attachments: HIVE-19104.2.patch, HIVE-19104.3.patch, 
> HIVE-19104.4.patch, HIVE-19104.patch
> When multiple MetaStore instances are started with 
> {{MetaStoreTestUtils.startMetaStoreWithRetry}} currently they use the same 
> JDBC url, and warehouse directory. This can cause problem in the tests

This message was sent by Atlassian JIRA

Reply via email to