Peter Vary commented on HIVE-19104:

{quote}Ok, then why do we just set {{javax.jdo.option.ConnectionURL}} inside 
{{MetaStoreTestUtils}} rather than doing the string replacement
Ok. Tomorrow I will create a new patch version where we set the warehouse dir, 
and the jdbc url in the same way, than we do it with the thrift uri.

{quote}Can the following code just be moved into a {{BeforeClass}} block?
Sure: Good idea! Thanks!
{quote}Why is {{MetastoreConf.newMetastoreConf(new Configuration(this.conf));}} 
necessary? Can't it just be {{MetastoreConf.newMetastoreConf(this.conf);}}
This particular test changes the conf. Since we initialize the conf once per 
test class, either we revert the changes done by the test, or copy it so we do 
not have a problem in the next tests

> When test MetaStore is started with retry the instances should be independent
> -----------------------------------------------------------------------------
>                 Key: HIVE-19104
>                 URL: https://issues.apache.org/jira/browse/HIVE-19104
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Peter Vary
>            Assignee: Peter Vary
>            Priority: Major
>         Attachments: HIVE-19104.2.patch, HIVE-19104.3.patch, HIVE-19104.patch
> When multiple MetaStore instances are started with 
> {{MetaStoreTestUtils.startMetaStoreWithRetry}} currently they use the same 
> JDBC url, and warehouse directory. This can cause problem in the tests

This message was sent by Atlassian JIRA

Reply via email to