[
https://issues.apache.org/jira/browse/HIVE-23617?focusedWorklogId=441926&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441926
]
ASF GitHub Bot logged work on HIVE-23617:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jun/20 17:32
Start Date: 05/Jun/20 17:32
Worklog Time Spent: 10m
Work Description: pgaref commented on a change in pull request #1063:
URL: https://github.com/apache/hive/pull/1063#discussion_r436063677
##########
File path:
storage-api/src/java/org/apache/hive/common/util/SuppressFBWarnings.java
##########
@@ -0,0 +1,19 @@
+package org.apache.hive.common.util;
+
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+
+@Retention(RetentionPolicy.CLASS)
+public @interface SuppressFBWarnings {
Review comment:
Hey @mustafaiman -- in the main pom.xml we are only using the
finbugs-maven-plugin and not the findbugs-annotation package (only hive-ql is
using it as dependency and I would like to remove it eventually).
In order to avoid adding jsut another dependency (findbugs-annotation), I
implemented the annotation as a separate class, Findbugs doesn't care in which
package the annotation is, so it works pretty well -- ideally we can also reuse
it across hive packages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 441926)
Time Spent: 0.5h (was: 20m)
> Fix FindBug issues in storage-api
> ---------------------------------
>
> Key: HIVE-23617
> URL: https://issues.apache.org/jira/browse/HIVE-23617
> Project: Hive
> Issue Type: Sub-task
> Components: storage-api
> Reporter: Panagiotis Garefalakis
> Assignee: Panagiotis Garefalakis
> Priority: Major
> Labels: pull-request-available
> Attachments: findbugsXml.xml
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> {code:java}
> mvn -DskipTests test-compile findbugs:findbugs -DskipTests=true -pl
> storage-api
> {code}
> {code:java}
> mvn findbugs:gui
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
