[
https://issues.apache.org/jira/browse/HIVE-23617?focusedWorklogId=443209&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-443209
]
ASF GitHub Bot logged work on HIVE-23617:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jun/20 16:42
Start Date: 09/Jun/20 16:42
Worklog Time Spent: 10m
Work Description: pgaref commented on a change in pull request #1063:
URL: https://github.com/apache/hive/pull/1063#discussion_r436654787
##########
File path:
storage-api/src/java/org/apache/hadoop/hive/common/io/encoded/EncodedColumnBatch.java
##########
@@ -78,13 +79,21 @@ public void setIndexBaseOffset(int indexBaseOffset) {
@Override
public String toString() {
- String bufStr = "";
+ StringBuilder sb = new StringBuilder();
if (cacheBuffers != null) {
- for (MemoryBuffer mb : cacheBuffers) {
- bufStr += mb.getClass().getSimpleName() + " with " +
mb.getByteBufferRaw().remaining() + " bytes, ";
+ Iterator<MemoryBuffer> iter = cacheBuffers.iterator();
+ while (iter.hasNext()) {
+ MemoryBuffer mb = iter.next();
+ sb.append(mb.getClass().getSimpleName());
+ sb.append(" with ");
+ sb.append(mb.getByteBufferRaw().remaining());
+ sb.append(" bytes");
+ if (iter.hasNext()) {
+ sb.append(", ");
Review comment:
Tests passed so this change should be safe.
##########
File path:
storage-api/src/java/org/apache/hadoop/hive/common/io/DiskRangeList.java
##########
@@ -228,6 +228,16 @@ public long getTotalLength() {
return result;
}
+ @Override
+ public int hashCode() {
+ return super.hashCode();
+ }
+
+ @Override
+ public boolean equals(Object other) {
+ return super.equals(other);
Review comment:
Addressed as part of 0e40c954e3aa7af7e932b1b26091012707b80fe2
As discussed, let's make sure we update such methods across packages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 443209)
Time Spent: 1h 40m (was: 1.5h)
> Fix FindBug issues in storage-api
> ---------------------------------
>
> Key: HIVE-23617
> URL: https://issues.apache.org/jira/browse/HIVE-23617
> Project: Hive
> Issue Type: Sub-task
> Components: storage-api
> Reporter: Panagiotis Garefalakis
> Assignee: Panagiotis Garefalakis
> Priority: Major
> Labels: pull-request-available
> Attachments: findbugsXml.xml
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> {code:java}
> mvn test-compile findbugs:findbugs -pl storage-api
> {code}
> {code:java}
> mvn findbugs:gui
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
