[
https://issues.apache.org/jira/browse/HIVE-23617?focusedWorklogId=441949&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441949
]
ASF GitHub Bot logged work on HIVE-23617:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jun/20 17:58
Start Date: 05/Jun/20 17:58
Worklog Time Spent: 10m
Work Description: mustafaiman commented on a change in pull request #1063:
URL: https://github.com/apache/hive/pull/1063#discussion_r436076795
##########
File path:
storage-api/src/java/org/apache/hive/common/util/SuppressFBWarnings.java
##########
@@ -0,0 +1,19 @@
+package org.apache.hive.common.util;
+
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+
+@Retention(RetentionPolicy.CLASS)
+public @interface SuppressFBWarnings {
Review comment:
If we are defining our own annotation, I would like to put it in a
common to prevent each module having their own copy of the same annotation. I
thought hive-common would be a good candidate but storage-api does not depend
on hive-common either. This looks like the only way then. Thanks for the link.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 441949)
Time Spent: 50m (was: 40m)
> Fix FindBug issues in storage-api
> ---------------------------------
>
> Key: HIVE-23617
> URL: https://issues.apache.org/jira/browse/HIVE-23617
> Project: Hive
> Issue Type: Sub-task
> Components: storage-api
> Reporter: Panagiotis Garefalakis
> Assignee: Panagiotis Garefalakis
> Priority: Major
> Labels: pull-request-available
> Attachments: findbugsXml.xml
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> {code:java}
> mvn -DskipTests test-compile findbugs:findbugs -DskipTests=true -pl
> storage-api
> {code}
> {code:java}
> mvn findbugs:gui
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
