[
https://issues.apache.org/jira/browse/HIVE-23617?focusedWorklogId=442015&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442015
]
ASF GitHub Bot logged work on HIVE-23617:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jun/20 19:58
Start Date: 05/Jun/20 19:58
Worklog Time Spent: 10m
Work Description: belugabehr commented on a change in pull request #1063:
URL: https://github.com/apache/hive/pull/1063#discussion_r436136581
##########
File path:
storage-api/src/java/org/apache/hadoop/hive/common/io/encoded/EncodedColumnBatch.java
##########
@@ -78,13 +79,21 @@ public void setIndexBaseOffset(int indexBaseOffset) {
@Override
public String toString() {
- String bufStr = "";
+ StringBuilder sb = new StringBuilder();
if (cacheBuffers != null) {
- for (MemoryBuffer mb : cacheBuffers) {
- bufStr += mb.getClass().getSimpleName() + " with " +
mb.getByteBufferRaw().remaining() + " bytes, ";
+ Iterator<MemoryBuffer> iter = cacheBuffers.iterator();
+ while (iter.hasNext()) {
+ MemoryBuffer mb = iter.next();
+ sb.append(mb.getClass().getSimpleName());
+ sb.append(" with ");
+ sb.append(mb.getByteBufferRaw().remaining());
+ sb.append(" bytes");
+ if (iter.hasNext()) {
+ sb.append(", ");
Review comment:
Will have to check this. I think from my own patch experience, that
this change might break a bunch of unit tests because they are checking the
output of `toString()` which previously always adds a comma, even if it's not
really needed. I'm not 100%, but just FYI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 442015)
Time Spent: 1.5h (was: 1h 20m)
> Fix FindBug issues in storage-api
> ---------------------------------
>
> Key: HIVE-23617
> URL: https://issues.apache.org/jira/browse/HIVE-23617
> Project: Hive
> Issue Type: Sub-task
> Components: storage-api
> Reporter: Panagiotis Garefalakis
> Assignee: Panagiotis Garefalakis
> Priority: Major
> Labels: pull-request-available
> Attachments: findbugsXml.xml
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> {code:java}
> mvn -DskipTests test-compile findbugs:findbugs -DskipTests=true -pl
> storage-api
> {code}
> {code:java}
> mvn findbugs:gui
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
