[
https://issues.apache.org/jira/browse/HIVE-23718?focusedWorklogId=447734&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-447734
]
ASF GitHub Bot logged work on HIVE-23718:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jun/20 09:47
Start Date: 18/Jun/20 09:47
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #1142:
URL: https://github.com/apache/hive/pull/1142#discussion_r442105092
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/Driver.java
##########
@@ -988,7 +741,7 @@ private void releaseContext() {
}
context.clear(deleteResultDir);
if (context.getHiveLocks() != null) {
- hiveLocks.addAll(context.getHiveLocks());
+ driverTxnHandler.addHiveLocksFromContext();
Review comment:
Do we need this magic? DriverTxnHandler already has a Context.
If I understand correctly this is just clearing the context at hand, should
be the responsibility of the DriverTxnHandler.... or even better it can have a
DriverTxnHandlerContext...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 447734)
Time Spent: 40m (was: 0.5h)
> Extract transaction handling from Driver
> ----------------------------------------
>
> Key: HIVE-23718
> URL: https://issues.apache.org/jira/browse/HIVE-23718
> Project: Hive
> Issue Type: Sub-task
> Components: HiveServer2
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
