[
https://issues.apache.org/jira/browse/HIVE-23718?focusedWorklogId=448059&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-448059
]
ASF GitHub Bot logged work on HIVE-23718:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jun/20 21:34
Start Date: 18/Jun/20 21:34
Worklog Time Spent: 10m
Work Description: miklosgergely commented on a change in pull request
#1142:
URL: https://github.com/apache/hive/pull/1142#discussion_r442515235
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/Driver.java
##########
@@ -988,7 +741,7 @@ private void releaseContext() {
}
context.clear(deleteResultDir);
if (context.getHiveLocks() != null) {
- hiveLocks.addAll(context.getHiveLocks());
+ driverTxnHandler.addHiveLocksFromContext();
Review comment:
The main problem here is that we have some HiveLocks in the hiveLocks
variable (previously in Driver, after this patch in DriverTxnHandler), and also
some HiveLocks in the Context. The two should be unified I believe, probably in
Context. I think it's a good goal, but I'd rather not put it into this patch,
as this is only moving code around. Let's do this in another jira, do you agree?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 448059)
Time Spent: 2h 10m (was: 2h)
> Extract transaction handling from Driver
> ----------------------------------------
>
> Key: HIVE-23718
> URL: https://issues.apache.org/jira/browse/HIVE-23718
> Project: Hive
> Issue Type: Sub-task
> Components: HiveServer2
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
