[
https://issues.apache.org/jira/browse/HIVE-23718?focusedWorklogId=448038&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-448038
]
ASF GitHub Bot logged work on HIVE-23718:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jun/20 21:13
Start Date: 18/Jun/20 21:13
Worklog Time Spent: 10m
Work Description: miklosgergely commented on a change in pull request
#1142:
URL: https://github.com/apache/hive/pull/1142#discussion_r442505140
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/Driver.java
##########
@@ -1112,15 +865,15 @@ public void destroy() {
boolean isTxnOpen = driverContext != null
&& driverContext.getTxnManager() != null
&& driverContext.getTxnManager().isTxnOpen();
- if (!hiveLocks.isEmpty() || isTxnOpen) {
+ if (!driverTxnHandler.hasHiveLock() || isTxnOpen) {
Review comment:
I agree, I'll modify this.
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/Driver.java
##########
@@ -1058,15 +811,15 @@ private int closeInProcess(boolean destroyed) {
releaseResStream();
releaseContext();
if (destroyed) {
- if (!hiveLocks.isEmpty()) {
+ if (!driverTxnHandler.hasHiveLock()) {
Review comment:
I agree, I'll modify this.
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/Driver.java
##########
@@ -565,9 +368,9 @@ public void lockAndRespond() throws
CommandProcessorException {
"No previously compiled query for driver - queryId=" +
driverContext.getQueryState().getQueryId());
}
- if (requiresLock()) {
Review comment:
I agree, I'll modify this.
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/Driver.java
##########
@@ -565,9 +368,9 @@ public void lockAndRespond() throws
CommandProcessorException {
"No previously compiled query for driver - queryId=" +
driverContext.getQueryState().getQueryId());
}
- if (requiresLock()) {
Review comment:
I agree, I'll modify it.
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/Driver.java
##########
@@ -1058,15 +811,15 @@ private int closeInProcess(boolean destroyed) {
releaseResStream();
releaseContext();
if (destroyed) {
- if (!hiveLocks.isEmpty()) {
+ if (!driverTxnHandler.hasHiveLock()) {
Review comment:
I agree, I'll modify this.
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/Driver.java
##########
@@ -1112,15 +865,15 @@ public void destroy() {
boolean isTxnOpen = driverContext != null
&& driverContext.getTxnManager() != null
&& driverContext.getTxnManager().isTxnOpen();
- if (!hiveLocks.isEmpty() || isTxnOpen) {
+ if (!driverTxnHandler.hasHiveLock() || isTxnOpen) {
Review comment:
I agree, I'll modify this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 448038)
Time Spent: 1.5h (was: 1h 20m)
> Extract transaction handling from Driver
> ----------------------------------------
>
> Key: HIVE-23718
> URL: https://issues.apache.org/jira/browse/HIVE-23718
> Project: Hive
> Issue Type: Sub-task
> Components: HiveServer2
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
