[
https://issues.apache.org/jira/browse/HIVE-27013?focusedWorklogId=848958&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-848958
]
ASF GitHub Bot logged work on HIVE-27013:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Mar/23 13:27
Start Date: 03/Mar/23 13:27
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #4088:
URL: https://github.com/apache/hive/pull/4088#discussion_r1124453059
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -98,8 +98,12 @@ public void initialize(String inputName, Map<String, String>
properties) {
this.listAllTables =
Boolean.parseBoolean(properties.getOrDefault(LIST_ALL_TABLES,
LIST_ALL_TABLES_DEFAULT));
String fileIOImpl = properties.get(CatalogProperties.FILE_IO_IMPL);
- this.fileIO = fileIOImpl == null ? new HadoopFileIO(conf) :
CatalogUtil.loadFileIO(fileIOImpl, properties, conf);
-
+ if (fileIOImpl == null) {
Review Comment:
maybe just
````
this.fileIO = (fileIOImpl == null) ?
new HadoopFileIO(conf) : CatalogUtil.loadFileIO(fileIOImpl, properties,
conf);
this.fileIO.initialize(properties);
````
Issue Time Tracking
-------------------
Worklog Id: (was: 848958)
Time Spent: 1.5h (was: 1h 20m)
> Provide an option to enable iceberg manifest caching for all catalogs
> ---------------------------------------------------------------------
>
> Key: HIVE-27013
> URL: https://issues.apache.org/jira/browse/HIVE-27013
> Project: Hive
> Issue Type: Improvement
> Components: Iceberg integration
> Reporter: Rajesh Balamohan
> Assignee: Ayush Saxena
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> {color:#222222}I tried the following thinking that it would work with iceberg
> manifest caching; but it didn't.{color}
> {noformat}
> alter table store_sales set
> tblproperties('io.manifest.cache-enabled'='true');{noformat}
> {color:#222222}Creating this ticket as a placeholder to fix the same.{color}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
