[
https://issues.apache.org/jira/browse/HIVE-27013?focusedWorklogId=848987&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-848987
]
ASF GitHub Bot logged work on HIVE-27013:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Mar/23 15:33
Start Date: 03/Mar/23 15:33
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #4088:
URL: https://github.com/apache/hive/pull/4088#discussion_r1124431214
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java:
##########
@@ -243,11 +241,21 @@ static Optional<Catalog> loadCatalog(Configuration conf,
String catalogName) {
* @return complete map of catalog properties
*/
private static Map<String, String> getCatalogProperties(Configuration conf,
String catalogName, String catalogType) {
+ Map<String, String> defaultCatalogProperties = Maps.newHashMap();
Review Comment:
why do we need 2 hashmaps? how about this
````
private static Map<String, String> getCatalogProperties(Configuration
conf, String catalogName, String catalogType) {
Map<String, String> catalogProperties = Maps.newHashMap();
Stream<String> includePrefixes = Stream.of(
InputFormatConfig.CATALOG_DEFAULT_CONFIG_PREFIX,
InputFormatConfig.CATALOG_CONFIG_PREFIX + catalogName + "."
);
conf.forEach(config ->
includePrefixes.filter(key -> config.getKey().startsWith(key))
.findAny().ifPresent(keyPrefix -> {
String propName = config.getKey().substring(keyPrefix.length());
if (CATALOG_DEFAULT_CONFIG_PREFIX == keyPrefix) {
catalogProperties.putIfAbsent(propName, config.getValue());
} else {
catalogProperties.put(propName, config.getValue());
}
})
);
return addCatalogPropertiesIfMissing(conf, catalogType,
catalogProperties);
}
````
Issue Time Tracking
-------------------
Worklog Id: (was: 848987)
Time Spent: 1h 50m (was: 1h 40m)
> Provide an option to enable iceberg manifest caching for all catalogs
> ---------------------------------------------------------------------
>
> Key: HIVE-27013
> URL: https://issues.apache.org/jira/browse/HIVE-27013
> Project: Hive
> Issue Type: Improvement
> Components: Iceberg integration
> Reporter: Rajesh Balamohan
> Assignee: Ayush Saxena
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> {color:#222222}I tried the following thinking that it would work with iceberg
> manifest caching; but it didn't.{color}
> {noformat}
> alter table store_sales set
> tblproperties('io.manifest.cache-enabled'='true');{noformat}
> {color:#222222}Creating this ticket as a placeholder to fix the same.{color}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
