[
https://issues.apache.org/jira/browse/HIVE-27013?focusedWorklogId=849034&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-849034
]
ASF GitHub Bot logged work on HIVE-27013:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Mar/23 19:03
Start Date: 03/Mar/23 19:03
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #4088:
URL: https://github.com/apache/hive/pull/4088#discussion_r1124900883
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java:
##########
@@ -243,10 +241,18 @@ static Optional<Catalog> loadCatalog(Configuration conf,
String catalogName) {
* @return complete map of catalog properties
*/
private static Map<String, String> getCatalogProperties(Configuration conf,
String catalogName, String catalogType) {
- String keyPrefix = InputFormatConfig.CATALOG_CONFIG_PREFIX + catalogName;
- Map<String, String> catalogProperties = Streams.stream(conf.iterator())
- .filter(e -> e.getKey().startsWith(keyPrefix))
- .collect(Collectors.toMap(e ->
e.getKey().substring(keyPrefix.length() + 1), Map.Entry::getValue));
+ Map<String, String> catalogProperties = Maps.newHashMap();
+ conf.forEach(config -> {
+ if
(config.getKey().startsWith(InputFormatConfig.CATALOG_DEFAULT_CONFIG_PREFIX)) {
+ catalogProperties.putIfAbsent(
+
config.getKey().substring(InputFormatConfig.CATALOG_DEFAULT_CONFIG_PREFIX.length()),
config.getValue());
Review Comment:
formatting is not consistent, in this `if` branch `config.getValue()` is on
the same line with key, in the next `if` branch it's on a new line
Issue Time Tracking
-------------------
Worklog Id: (was: 849034)
Time Spent: 2h 10m (was: 2h)
> Provide an option to enable iceberg manifest caching for all catalogs
> ---------------------------------------------------------------------
>
> Key: HIVE-27013
> URL: https://issues.apache.org/jira/browse/HIVE-27013
> Project: Hive
> Issue Type: Improvement
> Components: Iceberg integration
> Reporter: Rajesh Balamohan
> Assignee: Ayush Saxena
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> {color:#222222}I tried the following thinking that it would work with iceberg
> manifest caching; but it didn't.{color}
> {noformat}
> alter table store_sales set
> tblproperties('io.manifest.cache-enabled'='true');{noformat}
> {color:#222222}Creating this ticket as a placeholder to fix the same.{color}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
