[
https://issues.apache.org/jira/browse/HIVE-27013?focusedWorklogId=849036&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-849036
]
ASF GitHub Bot logged work on HIVE-27013:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Mar/23 19:21
Start Date: 03/Mar/23 19:21
Worklog Time Spent: 10m
Work Description: ayushtkn commented on code in PR #4088:
URL: https://github.com/apache/hive/pull/4088#discussion_r1124916800
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java:
##########
@@ -243,10 +241,18 @@ static Optional<Catalog> loadCatalog(Configuration conf,
String catalogName) {
* @return complete map of catalog properties
*/
private static Map<String, String> getCatalogProperties(Configuration conf,
String catalogName, String catalogType) {
- String keyPrefix = InputFormatConfig.CATALOG_CONFIG_PREFIX + catalogName;
- Map<String, String> catalogProperties = Streams.stream(conf.iterator())
- .filter(e -> e.getKey().startsWith(keyPrefix))
- .collect(Collectors.toMap(e ->
e.getKey().substring(keyPrefix.length() + 1), Map.Entry::getValue));
+ Map<String, String> catalogProperties = Maps.newHashMap();
+ conf.forEach(config -> {
+ if
(config.getKey().startsWith(InputFormatConfig.CATALOG_DEFAULT_CONFIG_PREFIX)) {
+ catalogProperties.putIfAbsent(
+
config.getKey().substring(InputFormatConfig.CATALOG_DEFAULT_CONFIG_PREFIX.length()),
config.getValue());
Review Comment:
In the first one, when it is on the same line, there it doesn't crosses the
line limit, in the second one, it crosses the line limit, so it got wrapped out
to the next line. :)
I will push the first one also in the second line
Issue Time Tracking
-------------------
Worklog Id: (was: 849036)
Time Spent: 2h 20m (was: 2h 10m)
> Provide an option to enable iceberg manifest caching for all catalogs
> ---------------------------------------------------------------------
>
> Key: HIVE-27013
> URL: https://issues.apache.org/jira/browse/HIVE-27013
> Project: Hive
> Issue Type: Improvement
> Components: Iceberg integration
> Reporter: Rajesh Balamohan
> Assignee: Ayush Saxena
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> {color:#222222}I tried the following thinking that it would work with iceberg
> manifest caching; but it didn't.{color}
> {noformat}
> alter table store_sales set
> tblproperties('io.manifest.cache-enabled'='true');{noformat}
> {color:#222222}Creating this ticket as a placeholder to fix the same.{color}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
