hansva commented on issue #8321: URL: https://github.com/apache/hop/issues/8321#issuecomment-5655826835
I'd have to take a closer look at the code. But some things do worry me... 1) Breaking the public API ( we don't know who is directly using these outside the project) 2) Stack traces are gone in the current PR form; might be a simple fix 3) We are losing logging levels `DETAILED comes back out of the buffer as BASIC (7 Hop levels → 5 SLF4J levels → 7 Hop levels). Anything reading HopLoggingEvent.getLevel()` 4) Hot path, no log file: 20k logBasic -> degraded from 1.17 µs/line to 4.44 µs/line 5) Using log4j2.xml with additivity="false" on org.apache.hop will leave your entire UI/hop-server empty, as nothing goes to our buffers. and we are not gaining much. The things you need can be done by rewriting the `Slf4jLoggingEventListener` and adding MDC in there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
